From 0a1d98c7666ea56fe9544c94c21a67cdcc7b1383 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Wed, 6 Sep 2017 00:00:46 +0000 Subject: [sanitizer_common][Fuchsia] Update Fuchsia sanitizer markup Include URLs to the markup format specification in code comments. Use sanitizer markup in the sancov message about a dump just produced. Patch by Roland McGrath Differential Revision: https://reviews.llvm.org/D37273 git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@312596 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/sanitizer_common/sanitizer_coverage_fuchsia.cc | 11 +++++++---- lib/sanitizer_common/sanitizer_symbolizer_fuchsia.cc | 4 ++-- 2 files changed, 9 insertions(+), 6 deletions(-) (limited to 'lib') diff --git a/lib/sanitizer_common/sanitizer_coverage_fuchsia.cc b/lib/sanitizer_common/sanitizer_coverage_fuchsia.cc index 491d5a215..4d20bb2ed 100644 --- a/lib/sanitizer_common/sanitizer_coverage_fuchsia.cc +++ b/lib/sanitizer_common/sanitizer_coverage_fuchsia.cc @@ -96,10 +96,13 @@ class TracePcGuardController { __sanitizer_publish_data(kSancovSinkName, vmo_); vmo_ = MX_HANDLE_INVALID; - // This will route to __sanitizer_log_write, which will ensure - // that information about shared libraries is written out. - Printf("SanitizerCoverage: published '%s' with up to %u PCs\n", vmo_name_, - next_index_ - 1); + // This will route to __sanitizer_log_write, which will ensure that + // information about shared libraries is written out. This message + // uses the `dumpfile` symbolizer markup element to highlight the + // dump. See the explanation for this in: + // https://fuchsia.googlesource.com/magenta/+/master/docs/symbolizer_markup.md + Printf("SanitizerCoverage: {{{dumpfile:%s:%s}}} with up to %u PCs\n", + kSancovSinkName, vmo_name_, next_index_ - 1); } } diff --git a/lib/sanitizer_common/sanitizer_symbolizer_fuchsia.cc b/lib/sanitizer_common/sanitizer_symbolizer_fuchsia.cc index 8e383dd8f..942029254 100644 --- a/lib/sanitizer_common/sanitizer_symbolizer_fuchsia.cc +++ b/lib/sanitizer_common/sanitizer_symbolizer_fuchsia.cc @@ -25,8 +25,8 @@ namespace __sanitizer { // symbol names, embedded in Fuchsia's symbolization markup format. // Fuchsia's logging infrastructure emits enough information about // process memory layout that a post-processing filter can do the -// symbolization and pretty-print the markup. -// TODO(mcgrathr): URL to markup format document +// symbolization and pretty-print the markup. See the spec at: +// https://fuchsia.googlesource.com/magenta/+/master/docs/symbolizer_markup.md // This is used by UBSan for type names, and by ASan for global variable names. constexpr const char *kFormatDemangle = "{{{symbol:%s}}}"; -- cgit v1.2.3