diff options
Diffstat (limited to 'lib/asan')
-rw-r--r-- | lib/asan/asan_activation.cc | 7 | ||||
-rw-r--r-- | lib/asan/asan_activation_flags.inc | 1 | ||||
-rw-r--r-- | lib/asan/asan_fake_stack.cc | 2 | ||||
-rw-r--r-- | lib/asan/asan_flags.cc | 15 | ||||
-rw-r--r-- | lib/asan/asan_mac.cc | 6 | ||||
-rw-r--r-- | lib/asan/asan_poisoning.cc | 4 | ||||
-rw-r--r-- | lib/asan/asan_rtl.cc | 3 |
7 files changed, 19 insertions, 19 deletions
diff --git a/lib/asan/asan_activation.cc b/lib/asan/asan_activation.cc index 50ba30bcb..3bc019848 100644 --- a/lib/asan/asan_activation.cc +++ b/lib/asan/asan_activation.cc @@ -53,6 +53,7 @@ static struct AsanDeactivatedFlags { f.poison_heap = poison_heap; cf.coverage = coverage; cf.coverage_dir = coverage_dir; + cf.verbosity = Verbosity(); cf.help = false; // this is activation-specific help // Check if activation flags need to be overriden. @@ -65,7 +66,9 @@ static struct AsanDeactivatedFlags { GetExtraActivationFlags(buf, sizeof(buf)); parser.ParseString(buf); - if (common_flags()->verbosity) ReportUnrecognizedFlags(); + SetVerbosity(cf.verbosity); + + if (Verbosity()) ReportUnrecognizedFlags(); if (cf.help) parser.PrintFlagDescriptions(); @@ -130,7 +133,7 @@ void AsanActivate() { ReInitializeAllocator(asan_deactivated_flags.allocator_options); asan_is_deactivated = false; - if (common_flags()->verbosity) { + if (Verbosity()) { Report("Activated with flags:\n"); asan_deactivated_flags.Print(); } diff --git a/lib/asan/asan_activation_flags.inc b/lib/asan/asan_activation_flags.inc index 4f891f9cd..d4c089ec6 100644 --- a/lib/asan/asan_activation_flags.inc +++ b/lib/asan/asan_activation_flags.inc @@ -31,4 +31,5 @@ COMMON_ACTIVATION_FLAG(bool, allocator_may_return_null) COMMON_ACTIVATION_FLAG(int, malloc_context_size) COMMON_ACTIVATION_FLAG(bool, coverage) COMMON_ACTIVATION_FLAG(const char *, coverage_dir) +COMMON_ACTIVATION_FLAG(int, verbosity) COMMON_ACTIVATION_FLAG(bool, help) diff --git a/lib/asan/asan_fake_stack.cc b/lib/asan/asan_fake_stack.cc index 86d285e36..bf4f1eb4c 100644 --- a/lib/asan/asan_fake_stack.cc +++ b/lib/asan/asan_fake_stack.cc @@ -60,7 +60,7 @@ FakeStack *FakeStack::Create(uptr stack_size_log) { void FakeStack::Destroy(int tid) { PoisonAll(0); - if (common_flags()->verbosity >= 2) { + if (Verbosity() >= 2) { InternalScopedString str(kNumberOfSizeClasses * 50); for (uptr class_id = 0; class_id < kNumberOfSizeClasses; class_id++) str.append("%zd: %zd/%zd; ", class_id, hint_position_[class_id], diff --git a/lib/asan/asan_flags.cc b/lib/asan/asan_flags.cc index 811007854..1d82ab0e7 100644 --- a/lib/asan/asan_flags.cc +++ b/lib/asan/asan_flags.cc @@ -79,14 +79,10 @@ void InitializeFlags(Flags *f) { // Override from user-specified string. const char *default_options = MaybeCallAsanDefaultOptions(); parser.ParseString(default_options); - VReport(1, "Using the defaults from __asan_default_options: %s\n", - MaybeCallAsanDefaultOptions()); // Override from command line. - if (const char *env = GetEnv("ASAN_OPTIONS")) { - parser.ParseString(env); - VReport(1, "Parsed ASAN_OPTIONS: %s\n", env); - } + const char *env = GetEnv("ASAN_OPTIONS"); + if (env) parser.ParseString(env); // Let activation flags override current settings. On Android they come // from a system property. On other platforms this is no-op. @@ -94,11 +90,12 @@ void InitializeFlags(Flags *f) { char buf[100]; GetExtraActivationFlags(buf, sizeof(buf)); parser.ParseString(buf); - if (buf[0] != '\0') - VReport(1, "Parsed activation flags: %s\n", buf); } - if (common_flags()->verbosity) ReportUnrecognizedFlags(); + SetVerbosity(common_flags()->verbosity); + + // TODO(eugenis): dump all flags at verbosity>=2? + if (Verbosity()) ReportUnrecognizedFlags(); if (common_flags()->help) parser.PrintFlagDescriptions(); diff --git a/lib/asan/asan_mac.cc b/lib/asan/asan_mac.cc index 202361420..2e0b2d372 100644 --- a/lib/asan/asan_mac.cc +++ b/lib/asan/asan_mac.cc @@ -313,7 +313,7 @@ asan_block_context_t *alloc_asan_context(void *ctxt, dispatch_function_t func, dispatch_function_t func) { \ GET_STACK_TRACE_THREAD; \ asan_block_context_t *asan_ctxt = alloc_asan_context(ctxt, func, &stack); \ - if (common_flags()->verbosity >= 2) { \ + if (Verbosity() >= 2) { \ Report(#dispatch_x_f "(): context: %p, pthread_self: %p\n", \ asan_ctxt, pthread_self()); \ PRINT_CURRENT_STACK(); \ @@ -331,7 +331,7 @@ INTERCEPTOR(void, dispatch_after_f, dispatch_time_t when, dispatch_function_t func) { GET_STACK_TRACE_THREAD; asan_block_context_t *asan_ctxt = alloc_asan_context(ctxt, func, &stack); - if (common_flags()->verbosity >= 2) { + if (Verbosity() >= 2) { Report("dispatch_after_f: %p\n", asan_ctxt); PRINT_CURRENT_STACK(); } @@ -344,7 +344,7 @@ INTERCEPTOR(void, dispatch_group_async_f, dispatch_group_t group, dispatch_function_t func) { GET_STACK_TRACE_THREAD; asan_block_context_t *asan_ctxt = alloc_asan_context(ctxt, func, &stack); - if (common_flags()->verbosity >= 2) { + if (Verbosity() >= 2) { Report("dispatch_group_async_f(): context: %p, pthread_self: %p\n", asan_ctxt, pthread_self()); PRINT_CURRENT_STACK(); diff --git a/lib/asan/asan_poisoning.cc b/lib/asan/asan_poisoning.cc index 11fa271b2..e2b1f4dc4 100644 --- a/lib/asan/asan_poisoning.cc +++ b/lib/asan/asan_poisoning.cc @@ -74,10 +74,10 @@ void FlushUnneededASanShadowMemory(uptr p, uptr size) { void AsanPoisonOrUnpoisonIntraObjectRedzone(uptr ptr, uptr size, bool poison) { uptr end = ptr + size; - if (common_flags()->verbosity) { + if (Verbosity()) { Printf("__asan_%spoison_intra_object_redzone [%p,%p) %zd\n", poison ? "" : "un", ptr, end, size); - if (common_flags()->verbosity >= 2) + if (Verbosity() >= 2) PRINT_CURRENT_STACK(); } CHECK(size); diff --git a/lib/asan/asan_rtl.cc b/lib/asan/asan_rtl.cc index db258e73e..63cbb3f6f 100644 --- a/lib/asan/asan_rtl.cc +++ b/lib/asan/asan_rtl.cc @@ -353,8 +353,7 @@ static void AsanInitInternal() { } #endif - if (common_flags()->verbosity) - PrintAddressSpaceLayout(); + if (Verbosity()) PrintAddressSpaceLayout(); DisableCoreDumperIfNecessary(); |