summaryrefslogtreecommitdiff
path: root/test/sanitizer_common
diff options
context:
space:
mode:
authorVitaly Buka <vitalybuka@google.com>2018-02-15 00:40:36 +0000
committerVitaly Buka <vitalybuka@google.com>2018-02-15 00:40:36 +0000
commit9815d7b45adfbf7abe14c4a794f891b83b2241fb (patch)
treea01fae0472ac32c2f3626876746f8467f0fe938a /test/sanitizer_common
parentcf74a02bf3b5785954b500ad6bc72b54d6b5a904 (diff)
[sanitizer] Fix flakiness in the tests
Seems tests fails if link already exists. Also removed duplicated part of tests. git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@325194 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/sanitizer_common')
-rw-r--r--test/sanitizer_common/TestCases/Posix/readlink.c8
-rw-r--r--test/sanitizer_common/TestCases/Posix/readlinkat.c1
2 files changed, 2 insertions, 7 deletions
diff --git a/test/sanitizer_common/TestCases/Posix/readlink.c b/test/sanitizer_common/TestCases/Posix/readlink.c
index 136074af6..ef0a4fe35 100644
--- a/test/sanitizer_common/TestCases/Posix/readlink.c
+++ b/test/sanitizer_common/TestCases/Posix/readlink.c
@@ -12,6 +12,7 @@ int main(int argc, char **argv) {
char symlink_path[PATH_MAX];
snprintf(symlink_path, sizeof(symlink_path), "%s_%d.symlink", argv[0],
getpid());
+ remove(symlink_path);
int res = symlink(argv[0], symlink_path);
assert(!res);
@@ -21,12 +22,5 @@ int main(int argc, char **argv) {
readlink_path[res2] = '\0';
assert(!strcmp(readlink_path, argv[0]));
- char readlinkat_path[PATH_MAX];
- res2 = readlinkat(AT_FDCWD, symlink_path, readlinkat_path,
- sizeof(readlink_path));
- assert(res2 >= 0);
- readlinkat_path[res2] = '\0';
- assert(!strcmp(readlinkat_path, argv[0]));
-
return 0;
}
diff --git a/test/sanitizer_common/TestCases/Posix/readlinkat.c b/test/sanitizer_common/TestCases/Posix/readlinkat.c
index 62ca7070d..0afb5efe6 100644
--- a/test/sanitizer_common/TestCases/Posix/readlinkat.c
+++ b/test/sanitizer_common/TestCases/Posix/readlinkat.c
@@ -11,6 +11,7 @@ int main(int argc, char **argv) {
char symlink_path[PATH_MAX];
snprintf(symlink_path, sizeof(symlink_path), "%s_%d.symlink", argv[0],
getpid());
+ remove(symlink_path);
int res = symlink(argv[0], symlink_path);
assert(!res);