diff options
| author | Roman Lebedev <lebedev.ri@gmail.com> | 2017-12-01 19:36:29 +0000 |
|---|---|---|
| committer | Roman Lebedev <lebedev.ri@gmail.com> | 2017-12-01 19:36:29 +0000 |
| commit | d3de79598999329c71a7fa2fc63c0e33a89098d1 (patch) | |
| tree | cd403088309d62d5efe0dff8ba6428e9fbef4df8 /test/profile | |
| parent | 420cd9e1652eda30d87cf9e5ce9cf25eb23c4b0f (diff) | |
[ubsan] Re-commit: lit changes for lld testing, future lto testing.
Summary:
As discussed in https://github.com/google/oss-fuzz/issues/933,
it would be really awesome to be able to use ThinLTO for fuzzing.
However, as @kcc has pointed out, it is currently undefined (untested)
whether the sanitizers actually function properly with LLD and/or LTO.
This patch is inspired by the cfi test, which already do test with LTO
(and/or LLD), since LTO is required for CFI to function.
I started with UBSan, because it's cmakelists / lit.* files appeared
to be the cleanest. This patch adds the infrastructure to easily add
LLD and/or LTO sub-variants of the existing lit test configurations.
Also, this patch adds the LLD flavor, that explicitly does use LLD to link.
The check-ubsan does pass on my machine. And to minimize the [initial]
potential buildbot breakage i have put some restrictions on this flavour.
Please review carefully, i have not worked with lit/sanitizer tests before.
The original attempt, r319525 was reverted in r319526 due
to the failures in compiler-rt standalone builds.
Reviewers: eugenis, vitalybuka
Reviewed By: eugenis
Subscribers: #sanitizers, pcc, kubamracek, mgorny, llvm-commits, mehdi_amini, inglorion, kcc
Differential Revision: https://reviews.llvm.org/D39508
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@319575 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/profile')
| -rw-r--r-- | test/profile/Linux/lit.local.cfg | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/test/profile/Linux/lit.local.cfg b/test/profile/Linux/lit.local.cfg index 410ffd8c5..98d79518b 100644 --- a/test/profile/Linux/lit.local.cfg +++ b/test/profile/Linux/lit.local.cfg @@ -20,7 +20,9 @@ def is_gold_linker_available(): if not '-plugin' in ld_out: return False - clang_cmd = subprocess.Popen([config.clang, '-fuse-ld=gold', '-xc', '-'], + # config.clang is not guaranteed to be just the executable! + clang_cmd = subprocess.Popen(" ".join([config.clang, '-fuse-ld=gold', '-xc', '-']), + shell=True, universal_newlines = True, stdin = subprocess.PIPE, stdout = subprocess.PIPE, |