diff options
| author | Alex Shlyapnikov <alekseys@google.com> | 2018-03-28 18:22:40 +0000 |
|---|---|---|
| committer | Alex Shlyapnikov <alekseys@google.com> | 2018-03-28 18:22:40 +0000 |
| commit | 85f6bace7a20b03d7a754d83a1b655b504eee0e3 (patch) | |
| tree | ec96f5db4dbeeb76722f17629975eb875e671de5 /test/lsan | |
| parent | d2575a962bced93ad1d1bc9c6551b9f54ccd71ef (diff) | |
[ASan] Report proper ASan error on allocator failures instead of CHECK(0)-ing
Summary:
Currently many allocator specific errors (OOM, for example) are reported as
a text message and CHECK(0) termination, not stack, no details, not too
helpful nor informative. To improve the situation, ASan detailed errors were
defined and reported under the appropriate conditions.
Issue: https://github.com/google/sanitizers/issues/887
Reviewers: eugenis
Subscribers: kubamracek, delcypher, #sanitizers, llvm-commits
Differential Revision: https://reviews.llvm.org/D44404
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@328722 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/lsan')
| -rw-r--r-- | test/lsan/TestCases/allocator_returns_null.cc | 22 |
1 files changed, 14 insertions, 8 deletions
diff --git a/test/lsan/TestCases/allocator_returns_null.cc b/test/lsan/TestCases/allocator_returns_null.cc index 28dd696dc..722cc5c4e 100644 --- a/test/lsan/TestCases/allocator_returns_null.cc +++ b/test/lsan/TestCases/allocator_returns_null.cc @@ -30,12 +30,16 @@ // RUN: %env_lsan_opts=allocator_may_return_null=0 not %run %t new 2>&1 \ // RUN: | FileCheck %s --check-prefix=CHECK-nCRASH // RUN: %env_lsan_opts=allocator_may_return_null=1 not %run %t new 2>&1 \ -// RUN: | FileCheck %s --check-prefix=CHECK-nCRASH +// RUN: | FileCheck %s --check-prefix=CHECK-nCRASH-OOM // RUN: %env_lsan_opts=allocator_may_return_null=0 not %run %t new-nothrow 2>&1 \ // RUN: | FileCheck %s --check-prefix=CHECK-nnCRASH // RUN: %env_lsan_opts=allocator_may_return_null=1 %run %t new-nothrow 2>&1 \ // RUN: | FileCheck %s --check-prefix=CHECK-nnNULL +// TODO(alekseyshl): Enable it back for standalone LSan mode when CHECK(0) in +// LSan allocator are converted to proper errors (see D44404 for the reference). +// REQUIRES: asan + #include <assert.h> #include <errno.h> #include <stdio.h> @@ -98,19 +102,21 @@ int main(int argc, char **argv) { } // CHECK-mCRASH: malloc: -// CHECK-mCRASH: Sanitizer's allocator is terminating the process +// CHECK-mCRASH: SUMMARY: AddressSanitizer: allocation-size-too-big // CHECK-cCRASH: calloc: -// CHECK-cCRASH: Sanitizer's allocator is terminating the process +// CHECK-cCRASH: SUMMARY: AddressSanitizer: allocation-size-too-big // CHECK-coCRASH: calloc-overflow: -// CHECK-coCRASH: Sanitizer's allocator is terminating the process +// CHECK-coCRASH: SUMMARY: AddressSanitizer: calloc-overflow // CHECK-rCRASH: realloc: -// CHECK-rCRASH: Sanitizer's allocator is terminating the process +// CHECK-rCRASH: SUMMARY: AddressSanitizer: allocation-size-too-big // CHECK-mrCRASH: realloc-after-malloc: -// CHECK-mrCRASH: Sanitizer's allocator is terminating the process +// CHECK-mrCRASH: SUMMARY: AddressSanitizer: allocation-size-too-big // CHECK-nCRASH: new: -// CHECK-nCRASH: Sanitizer's allocator is terminating the process +// CHECK-nCRASH: SUMMARY: AddressSanitizer: allocation-size-too-big +// CHECK-nCRASH-OOM: new: +// CHECK-nCRASH-OOM: SUMMARY: AddressSanitizer: out-of-memory // CHECK-nnCRASH: new-nothrow: -// CHECK-nnCRASH: Sanitizer's allocator is terminating the process +// CHECK-nnCRASH: SUMMARY: AddressSanitizer: allocation-size-too-big // CHECK-mNULL: malloc: // CHECK-mNULL: errno: 12 |