diff options
author | Kuba Brecka <kuba.brecka@gmail.com> | 2015-02-22 11:12:17 +0000 |
---|---|---|
committer | Kuba Brecka <kuba.brecka@gmail.com> | 2015-02-22 11:12:17 +0000 |
commit | ace7f28e7b046289be5103f8306e1cdcb10c9c2d (patch) | |
tree | 6660052357da293064c535fd3b6348366388cf5e /test/asan/TestCases/gc-test.cc | |
parent | c7e240ea72de505b2f42451b928afafddb077a15 (diff) |
Fix gc-test.cc to work under higher -O levels
The gc-test.cc tries underflows of a variable up to -32 bytes, but on i386, the left redzone is not 32 bytes, it’s only 16 bytes and therefore the access to var[-32] is completely off. The reason why this test didn’t fail before is that we’ve been lucky and there was another variable before the var array, which was also instrumented. This fix uses “-32” for 64-bit systems and “-16” for 32-bit.
Reviewed at http://reviews.llvm.org/D7809
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@230172 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/asan/TestCases/gc-test.cc')
-rw-r--r-- | test/asan/TestCases/gc-test.cc | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/test/asan/TestCases/gc-test.cc b/test/asan/TestCases/gc-test.cc index ffbea85b2..944590a28 100644 --- a/test/asan/TestCases/gc-test.cc +++ b/test/asan/TestCases/gc-test.cc @@ -1,6 +1,9 @@ // RUN: %clangxx_asan %s -pthread -o %t // RUN: env ASAN_OPTIONS=detect_stack_use_after_return=1 %run %t 2>&1 | FileCheck %s --check-prefix=CHECK1 // RUN: env ASAN_OPTIONS=detect_stack_use_after_return=0 %run %t 2>&1 | FileCheck %s --check-prefix=CHECK0 +// RUN: %clangxx_asan -O3 %s -pthread -o %t +// RUN: env ASAN_OPTIONS=detect_stack_use_after_return=1 %run %t 2>&1 | FileCheck %s --check-prefix=CHECK1 +// RUN: env ASAN_OPTIONS=detect_stack_use_after_return=0 %run %t 2>&1 | FileCheck %s --check-prefix=CHECK0 // REQUIRES: stable-runtime #include <assert.h> @@ -9,6 +12,7 @@ #include <sanitizer/asan_interface.h> static const int kNumThreads = 2; +static const int kLeftRedzoneSize = sizeof(void *) * 4; void *Thread(void *unused) { void *fake_stack = __asan_get_current_fake_stack(); @@ -23,7 +27,7 @@ void *Thread(void *unused) { assert(real_stack); assert((char*)beg <= (char*)&var[0]); assert((char*)end > (char*)&var[0]); - for (int i = -32; i < 15; i++) { + for (int i = -kLeftRedzoneSize; i < 15; i++) { void *beg1, *end1; char *ptr = &var[0] + i; void *real_stack1 = |