diff options
| author | Chandler Carruth <chandlerc@gmail.com> | 2012-09-11 01:13:51 +0000 |
|---|---|---|
| committer | Chandler Carruth <chandlerc@gmail.com> | 2012-09-11 01:13:51 +0000 |
| commit | cb9bd24e5f226b9a922098403cbd1589be39e605 (patch) | |
| tree | 7d04a50255b13f68e7de982531af4c38a8e9aff0 /lib | |
| parent | 78aedd464282595ba2c7bf83ddc4978117925217 (diff) | |
Revert r163411 based on review discussion.
In code review, it looked like these warnings do not actually fire with
modern Clang or GCC. However, the pragma is flat out rejected by GCC in
many configurations (-Werror) so it ended up causing more problems than
it fixed.
Daniel agreed with reverting this, but I think didn't have time to get
to it.
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@163583 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/asan/asan_report.cc | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/lib/asan/asan_report.cc b/lib/asan/asan_report.cc index 5138820a2..2a00c4e69 100644 --- a/lib/asan/asan_report.cc +++ b/lib/asan/asan_report.cc @@ -270,9 +270,6 @@ class ScopedInErrorReport { } }; -#pragma clang diagnostic push -#pragma clang diagnostic ignored "-Winvalid-noreturn" - void ReportSIGSEGV(uptr pc, uptr sp, uptr bp, uptr addr) { ScopedInErrorReport in_report; Report("ERROR: AddressSanitizer crashed on unknown address %p" @@ -329,8 +326,6 @@ void ReportStringFunctionMemoryRangesOverlap( DescribeAddress((uptr)offset2, length2); } -#pragma clang diagnostic pop - // ----------------------- Mac-specific reports ----------------- {{{1 void WarnMacFreeUnallocated( @@ -344,9 +339,6 @@ void WarnMacFreeUnallocated( DescribeHeapAddress(addr, 1); } -#pragma clang diagnostic push -#pragma clang diagnostic ignored "-Winvalid-noreturn" - void ReportMacMzReallocUnknown( uptr addr, uptr zone_ptr, const char *zone_name, StackTrace *stack) { ScopedInErrorReport in_report; @@ -369,8 +361,6 @@ void ReportMacCfReallocUnknown( DescribeHeapAddress(addr, 1); } -#pragma clang diagnostic pop - } // namespace __asan // --------------------------- Interface --------------------- {{{1 |