diff options
| author | Alexey Samsonov <samsonov@google.com> | 2013-02-25 09:00:03 +0000 |
|---|---|---|
| committer | Alexey Samsonov <samsonov@google.com> | 2013-02-25 09:00:03 +0000 |
| commit | 7907f1d0bd86e83677f8ae3bea7dc484546042cd (patch) | |
| tree | 649416ac327957241b591a45d0897fc8e7f55aad /lib | |
| parent | 8a6b5e551ab8a331f7e7bc4bfcd74926fbffa3f6 (diff) | |
[Sanitizer] fix signed/unsigned compare warnings in sanitizer_stacktrace_test. Build sanitizer_common tests with -Werror as we use predictable just-built Clang for building them
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@176014 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/sanitizer_common/tests/CMakeLists.txt | 2 | ||||
| -rw-r--r-- | lib/sanitizer_common/tests/sanitizer_stacktrace_test.cc | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/lib/sanitizer_common/tests/CMakeLists.txt b/lib/sanitizer_common/tests/CMakeLists.txt index 41a0bf167..111dfeefd 100644 --- a/lib/sanitizer_common/tests/CMakeLists.txt +++ b/lib/sanitizer_common/tests/CMakeLists.txt @@ -54,7 +54,7 @@ macro(add_sanitizer_tests_for_arch arch) -I${COMPILER_RT_SOURCE_DIR}/include -I${COMPILER_RT_SOURCE_DIR}/lib -I${COMPILER_RT_SOURCE_DIR}/lib/sanitizer_common - -O2 -g ${TARGET_FLAGS}) + -O2 -g -Wall -Werror ${TARGET_FLAGS}) set(SANITIZER_TEST_LINK_FLAGS -lstdc++ -lpthread ${TARGET_FLAGS}) set(SANITIZER_TEST_OBJECTS) foreach(source ${SANITIZER_TEST_SOURCES}) diff --git a/lib/sanitizer_common/tests/sanitizer_stacktrace_test.cc b/lib/sanitizer_common/tests/sanitizer_stacktrace_test.cc index 2a2cfe676..87f3748b6 100644 --- a/lib/sanitizer_common/tests/sanitizer_stacktrace_test.cc +++ b/lib/sanitizer_common/tests/sanitizer_stacktrace_test.cc @@ -31,7 +31,7 @@ class FastUnwindTest : public ::testing::Test { void FastUnwindTest::SetUp() { // Fill an array of pointers with fake fp+retaddr pairs. Frame pointers have // even indices. - for (int i = 0; i+1 < ARRAY_SIZE(fake_stack); i += 2) { + for (uptr i = 0; i+1 < ARRAY_SIZE(fake_stack); i += 2) { fake_stack[i] = (uptr)&fake_stack[i+2]; // fp fake_stack[i+1] = i+1; // retaddr } @@ -54,7 +54,7 @@ TEST_F(FastUnwindTest, Basic) { trace.FastUnwindStack(start_pc, (uptr)&fake_stack[0], fake_top, fake_bottom); // Should get all on-stack retaddrs and start_pc. - EXPECT_EQ(6, trace.size); + EXPECT_EQ(6U, trace.size); EXPECT_EQ(start_pc, trace.trace[0]); for (int i = 1; i <= 5; i++) { EXPECT_EQ(i*2 - 1, trace.trace[i]); @@ -68,7 +68,7 @@ TEST_F(FastUnwindTest, FramePointerLoop) { trace.FastUnwindStack(start_pc, (uptr)&fake_stack[0], fake_top, fake_bottom); // Should get all on-stack retaddrs up to the 4th slot and start_pc. - EXPECT_EQ(4, trace.size); + EXPECT_EQ(4U, trace.size); EXPECT_EQ(start_pc, trace.trace[0]); for (int i = 1; i <= 3; i++) { EXPECT_EQ(i*2 - 1, trace.trace[i]); |