diff options
author | Kostya Serebryany <kcc@google.com> | 2017-09-15 22:10:36 +0000 |
---|---|---|
committer | Kostya Serebryany <kcc@google.com> | 2017-09-15 22:10:36 +0000 |
commit | 4c32603421b9d0fec32fc9b6d11661babdfc21bf (patch) | |
tree | 1e13c0989f0cd5819dfba0f43800884cfcaca403 /lib | |
parent | f621dd83d4c4f4aaff040b2ce1788e205c012ff0 (diff) |
[libFuzzer] minor refactoring, NFC
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@313406 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib')
-rw-r--r-- | lib/fuzzer/FuzzerDriver.cpp | 6 | ||||
-rw-r--r-- | lib/fuzzer/FuzzerMerge.cpp | 3 | ||||
-rw-r--r-- | lib/fuzzer/FuzzerTracePC.h | 2 |
3 files changed, 4 insertions, 7 deletions
diff --git a/lib/fuzzer/FuzzerDriver.cpp b/lib/fuzzer/FuzzerDriver.cpp index 804f426e9..cc995348e 100644 --- a/lib/fuzzer/FuzzerDriver.cpp +++ b/lib/fuzzer/FuzzerDriver.cpp @@ -471,9 +471,8 @@ int AnalyzeDictionary(Fuzzer *F, const Vector<Unit>& Dict, // Get coverage for the testcase without modifications. F->ExecuteCallback(C.data(), C.size()); InitialFeatures.clear(); - TPC.CollectFeatures([&](size_t Feature) -> bool { + TPC.CollectFeatures([&](size_t Feature) { InitialFeatures.push_back(Feature); - return true; }); for (size_t i = 0; i < Dict.size(); ++i) { @@ -498,9 +497,8 @@ int AnalyzeDictionary(Fuzzer *F, const Vector<Unit>& Dict, // Get coverage for testcase with masked occurrences of dictionary unit. F->ExecuteCallback(Data.data(), Data.size()); ModifiedFeatures.clear(); - TPC.CollectFeatures([&](size_t Feature) -> bool { + TPC.CollectFeatures([&](size_t Feature) { ModifiedFeatures.push_back(Feature); - return true; }); if (InitialFeatures == ModifiedFeatures) diff --git a/lib/fuzzer/FuzzerMerge.cpp b/lib/fuzzer/FuzzerMerge.cpp index 78f2253a4..03cf00a56 100644 --- a/lib/fuzzer/FuzzerMerge.cpp +++ b/lib/fuzzer/FuzzerMerge.cpp @@ -241,10 +241,9 @@ void Fuzzer::CrashResistantMergeInternalStep(const std::string &CFPath) { // So it makes no sense to record all features for all files, instead we // only record features that were not seen before. Set<size_t> UniqFeatures; - TPC.CollectFeatures([&](size_t Feature) -> bool { + TPC.CollectFeatures([&](size_t Feature) { if (AllFeatures.insert(Feature).second) UniqFeatures.insert(Feature); - return true; }); // Show stats. if (!(TotalNumberOfRuns & (TotalNumberOfRuns - 1))) diff --git a/lib/fuzzer/FuzzerTracePC.h b/lib/fuzzer/FuzzerTracePC.h index 54172608d..743db5483 100644 --- a/lib/fuzzer/FuzzerTracePC.h +++ b/lib/fuzzer/FuzzerTracePC.h @@ -208,7 +208,7 @@ unsigned CounterToFeature(T Counter) { return Bit; } -template <class Callback> // bool Callback(size_t Feature) +template <class Callback> // void Callback(size_t Feature) ATTRIBUTE_NO_SANITIZE_ADDRESS __attribute__((noinline)) void TracePC::CollectFeatures(Callback HandleFeature) const { |