diff options
| author | Dean Michael Berris <dberris@google.com> | 2017-12-05 12:08:56 +0000 |
|---|---|---|
| committer | Dean Michael Berris <dberris@google.com> | 2017-12-05 12:08:56 +0000 |
| commit | faed8464752e5c9ff234c96f167dda4bc448e618 (patch) | |
| tree | 0c346c35f2fe597a55695eb30ca3db177af1e9b4 /lib/xray/xray_flags.inc | |
| parent | 0234ef5fc965f8b87cd249997459dd885602972d (diff) | |
[XRay][compiler-rt] Implement logging implementation registration
Summary:
This change allows for registration of multiple logging implementations
through a central mechanism in XRay, mapping an implementation to a
"mode". Modes are strings that are used as keys to determine which
implementation to install through a single API. This mechanism allows
users to choose which implementation to install either from the
environment variable 'XRAY_OPTIONS' with the `xray_mode=` flag, or
programmatically using the `__xray_select_mode(...)` function.
Here, we introduce two API functions for the XRay logging:
__xray_log_register_mode(Mode, Impl): Associates an XRayLogImpl to a
string Mode. We can only have one implementation associated with a given
Mode.
__xray_log_select_mode(Mode): Finds the associated Impl for Mode and
installs it as if by calling `__xray_set_log_impl(...)`.
Along with these changes, we also deprecate the xray_naive_log and
xray_fdr_log flags and encourage users to instead use the xray_mode
flag.
Reviewers: kpw, dblaikie, eizan, pelikan
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D40703
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@319759 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/xray/xray_flags.inc')
| -rw-r--r-- | lib/xray/xray_flags.inc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/xray/xray_flags.inc b/lib/xray/xray_flags.inc index c4238ff88..934fb2986 100644 --- a/lib/xray/xray_flags.inc +++ b/lib/xray/xray_flags.inc @@ -18,10 +18,12 @@ XRAY_FLAG(bool, patch_premain, false, "Whether to patch instrumentation points before main.") XRAY_FLAG(const char *, xray_logfile_base, "xray-log.", "Filename base for the xray logfile.") +XRAY_FLAG(const char *, xray_mode, "", "Mode to install by default.") + // Basic (Naive) Mode logging options. XRAY_FLAG(bool, xray_naive_log, false, - "Whether to install the naive log implementation.") + "DEPRECATED: Use xray_mode=xray-basic instead.") XRAY_FLAG(int, xray_naive_log_func_duration_threshold_us, 5, "Naive logging will try to skip functions that execute for fewer " "microseconds than this threshold.") @@ -33,7 +35,7 @@ XRAY_FLAG(int, xray_naive_log_thread_buffer_size, 1024, // FDR (Flight Data Recorder) Mode logging options. XRAY_FLAG(bool, xray_fdr_log, false, - "Whether to install the flight data recorder logging implementation.") + "DEPRECATED: Use xray_mode=xray-fdr instead.") XRAY_FLAG(int, xray_fdr_log_func_duration_threshold_us, 5, "FDR logging will try to skip functions that execute for fewer " "microseconds than this threshold.") |