diff options
| author | Alexander Potapenko <glider@google.com> | 2017-05-12 09:39:32 +0000 |
|---|---|---|
| committer | Alexander Potapenko <glider@google.com> | 2017-05-12 09:39:32 +0000 |
| commit | 929d2ccbf3afd1fc69a91aca258c177175ff900e (patch) | |
| tree | 44c88048dfd67b5abef048c4497c9ae968c62b2a /lib/msan/tests | |
| parent | 7fdfa4b8d87e169d47e17c9997528546282a57b5 (diff) | |
[msan] Remove a failing test from MemorySanitizer.ICmpRelational
This is a follow-up to r302787, which broke MemorySanitizer.ICmpRelational.
MSan is now reporting a false positive on the following test case:
TestForNotPoisoned((poisoned(-1, 0x80000000U) >= poisoned(-1, 0U)))
, which is sort of anticipated, because we're approximating the comparison
with an OR of the arguments' shadow values.
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@302887 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/msan/tests')
| -rw-r--r-- | lib/msan/tests/msan_test.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/msan/tests/msan_test.cc b/lib/msan/tests/msan_test.cc index 40f56270a..58f695e69 100644 --- a/lib/msan/tests/msan_test.cc +++ b/lib/msan/tests/msan_test.cc @@ -3724,8 +3724,10 @@ TEST(MemorySanitizer, ICmpRelational) { EXPECT_POISONED(poisoned(6, 0xF) > poisoned(7, 0)); EXPECT_POISONED(poisoned(0xF, 0xF) > poisoned(7, 0)); - - EXPECT_NOT_POISONED(poisoned(-1, 0x80000000U) >= poisoned(-1, 0U)); + // Note that "icmp op X, Y" is approximated with "or shadow(X), shadow(Y)" + // and therefore may generate false positives in some cases, e.g. the + // following one: + // EXPECT_NOT_POISONED(poisoned(-1, 0x80000000U) >= poisoned(-1, 0U)); } #if MSAN_HAS_M128 |