summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorKostya Kortchinsky <kostyak@google.com>2017-09-14 20:34:32 +0000
committerKostya Kortchinsky <kostyak@google.com>2017-09-14 20:34:32 +0000
commit9ff24034ff195b03df11b09ee2c55462f8489448 (patch)
tree3b8144c936827f634aa41629b29d76378b722f96 /include
parentaa753d2dffec736c1389b876a55f6390c70d8e71 (diff)
[scudo] Fix bad request handling when allocator has not been initialized
Summary: In a few functions (`scudoMemalign` and the like), we would call `ScudoAllocator::FailureHandler::OnBadRequest` if the parameters didn't check out. The issue is that if the allocator had not been initialized (eg: if this is the first heap related function called), we would use variables like `allocator_may_return_null` and `exitcode` that still had their default value (as opposed to the one set by the user or the initialization path). To solve this, we introduce `handleBadRequest` that will call `initThreadMaybe`, allowing the options to be correctly initialized. Unfortunately, the tests were passing because `exitcode` was still 0, so the results looked like success. Change those tests to do what they were supposed to. Reviewers: alekseyshl Reviewed By: alekseyshl Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D37853 git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@313294 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions