diff options
author | Vedant Kumar <vsk@apple.com> | 2017-02-25 02:30:03 +0000 |
---|---|---|
committer | Vedant Kumar <vsk@apple.com> | 2017-02-25 02:30:03 +0000 |
commit | 83740ef4fd7b2c18bcbca00af68875e2e97aab35 (patch) | |
tree | 0553a89b5a7685c00c68b6afed0fb406f0d93748 /test/Profile | |
parent | 8989fd32d7473f2f82da784f9f1d50530fe2218b (diff) |
[profiling] Fix profile counter increment when emitting selects (PR32019)
Clang has logic to lower certain conditional expressions directly into
llvm select instructions. However, it does not emit the correct profile
counter increment as it does this: it emits an unconditional increment
of the counter for the 'then branch', even if the value selected is from
the 'else branch' (this is PR32019).
That means, given the following snippet, we would report that "0" is
selected twice, and that "1" is never selected:
int f1(int x) {
return x ? 0 : 1;
^2 ^0
}
f1(0);
f1(1);
Fix the problem by using the instrprof_increment_step intrinsic to do
the proper increment.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@296231 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/Profile')
-rw-r--r-- | test/Profile/c-ternary.c | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/test/Profile/c-ternary.c b/test/Profile/c-ternary.c new file mode 100644 index 0000000000..09e8329235 --- /dev/null +++ b/test/Profile/c-ternary.c @@ -0,0 +1,15 @@ +// RUN: %clang_cc1 -triple x86_64-apple-macosx10.11.0 -x c %s -o - -emit-llvm -fprofile-instrument=clang | FileCheck %s + +// PR32019: Clang can lower some ternary operator expressions to select +// instructions. Make sure we only increment the profile counter for the +// condition when the condition evaluates to true. +// CHECK-LABEL: define i32 @f1 +int f1(int x) { +// CHECK: [[TOBOOL:%.*]] = icmp ne i32 %1, 0 +// CHECK-NEXT: [[STEP:%.*]] = zext i1 [[TOBOOL]] to i64 +// CHECK-NEXT: [[COUNTER:%.*]] = load i64, i64* getelementptr inbounds ([2 x i64], [2 x i64]* @__profc_f1, i64 0, i64 1) +// CHECK-NEXT: add i64 [[COUNTER]], [[STEP]] +// CHECK: [[COND:%.*]] = select i1 [[TOBOOL]], i32 0, i32 1 + return x ? 0 : 1; +// CHECK: ret i32 [[COND]] +} |