diff options
| author | Hans Wennborg <hans@hanshq.net> | 2017-07-26 21:29:24 +0000 |
|---|---|---|
| committer | Hans Wennborg <hans@hanshq.net> | 2017-07-26 21:29:24 +0000 |
| commit | f8d10d48421b0092a15ab7dae8ad1d6b09e80794 (patch) | |
| tree | f26bdeb176c754baeb66b421540b78445f738875 /test/Parser | |
| parent | 563803fe16cbd881020e700f2583354afe19facc (diff) | |
Revert r309106 "Recommit r308327 2nd time: Add a warning for missing"
The warning fires on non-suspicious code in Chromium. Reverting until a
solution is figured out.
> Recommit r308327 2nd time: Add a warning for missing
> '#pragma pack (pop)' and suspicious uses of '#pragma pack' in included files
>
> The first recommit (r308441) caused a "non-default #pragma pack value might
> change the alignment of struct or union members in the included file" warning
> in LLVM itself. This recommit tweaks the added warning to avoid warnings for
> #includes that don't have any records that are affected by the non-default
> alignment. This tweak avoids the previously emitted warning in LLVM.
>
> Original message:
>
> This commit adds a new -Wpragma-pack warning. It warns in the following cases:
>
> - When a translation unit is missing terminating #pragma pack (pop) directives.
> - When entering an included file if the current alignment value as determined
> by '#pragma pack' directives is different from the default alignment value.
> - When leaving an included file that changed the state of the current alignment
> value.
>
> rdar://10184173
>
> Differential Revision: https://reviews.llvm.org/D35484
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@309186 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/Parser')
| -rw-r--r-- | test/Parser/pragma-options.c | 2 | ||||
| -rw-r--r-- | test/Parser/pragma-options.cpp | 2 | ||||
| -rw-r--r-- | test/Parser/pragma-pack.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/test/Parser/pragma-options.c b/test/Parser/pragma-options.c index a35f0b087e..d168a2751a 100644 --- a/test/Parser/pragma-options.c +++ b/test/Parser/pragma-options.c @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -triple i386-apple-darwin9 -Wno-pragma-pack -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple i386-apple-darwin9 -fsyntax-only -verify %s /* expected-warning {{expected 'align' following '#pragma options'}} */ #pragma options /* expected-warning {{expected '=' following '#pragma options align'}} */ #pragma options align diff --git a/test/Parser/pragma-options.cpp b/test/Parser/pragma-options.cpp index 8f5a2152c7..84cd38dfb3 100644 --- a/test/Parser/pragma-options.cpp +++ b/test/Parser/pragma-options.cpp @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -triple i386-apple-darwin9 -Wno-pragma-pack -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple i386-apple-darwin9 -fsyntax-only -verify %s // expected-no-diagnostics class C { diff --git a/test/Parser/pragma-pack.c b/test/Parser/pragma-pack.c index d2aefaa888..0859f4157c 100644 --- a/test/Parser/pragma-pack.c +++ b/test/Parser/pragma-pack.c @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -fsyntax-only -Wno-pragma-pack -verify %s +// RUN: %clang_cc1 -fsyntax-only -verify %s // Note that this puts the expected lines before the directives to work around // limitations in the -verify mode. |