diff options
| author | Erik Verbruggen <erikjv@me.com> | 2017-10-24 13:46:58 +0000 |
|---|---|---|
| committer | Erik Verbruggen <erikjv@me.com> | 2017-10-24 13:46:58 +0000 |
| commit | 47dbb7c0df89914d76d70960557124df96725c5d (patch) | |
| tree | 820689d59176e57636343e444c273fd74d328e91 /test/Index | |
| parent | 230376a3f6366a23eb9187be0d6b9a37ead024fe (diff) | |
Do not add a colon chunk to the code completion of class inheritance access modifiers
With enabled CINDEXTEST_CODE_COMPLETE_PATTERNS env option (which enables
IncludeCodePatterns in completion options) code completion after colon
currently suggests access modifiers with 2 completion chunks which is
incorrect.
Example:
class A : <Cursor>B
{
}
Currently we get 'NotImplemented:{TypedText public}{Colon :} (40)'
but the correct line is just 'NotImplemented:{TypedText public} (40)'
The fix introduces more specific scope that occurs between ':' and '{'
It allows us to determine when we don't need to add ':' as a second
chunk to the public/protected/private access modifiers.
Patch by Ivan Donchevskii!
Differential Revision: https://reviews.llvm.org/D38618
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@316436 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/Index')
| -rw-r--r-- | test/Index/complete-super.cpp | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/test/Index/complete-super.cpp b/test/Index/complete-super.cpp index 9ffa7c8a40..92d3f7f585 100644 --- a/test/Index/complete-super.cpp +++ b/test/Index/complete-super.cpp @@ -40,3 +40,8 @@ void B::bar(float real) { // CHECK-ACCESS-PATTERN: NotImplemented:{TypedText private}{Colon :} (40) // CHECK-ACCESS-PATTERN: NotImplemented:{TypedText protected}{Colon :} (40) // CHECK-ACCESS-PATTERN: NotImplemented:{TypedText public}{Colon :} (40) + +// RUN: env CINDEXTEST_CODE_COMPLETE_PATTERNS=1 c-index-test -code-completion-at=%s:10:12 %s | FileCheck -check-prefix=CHECK-INHERITANCE-PATTERN %s +// CHECK-INHERITANCE-PATTERN: NotImplemented:{TypedText private} (40) +// CHECK-INHERITANCE-PATTERN: NotImplemented:{TypedText protected} (40) +// CHECK-INHERITANCE-PATTERN: NotImplemented:{TypedText public} (40) |