From bd140f1f5ef06b801156c787331f2d3ad72320a1 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Wed, 10 Jan 2018 23:14:06 +0000 Subject: Fix gdb.ada/bp_c_mixed_case.exp (PR gdb/22670) The problem here is that we are using the user-provided lookup name literally for name comparisons. I.e., "" with the "<>"s included. This commit fixes the minsym lookup case. psymbol/symbol lookup will be fixed in a follow up. In the minsym case, we're using using the user-provided lookup name literally for linkage name comparisons. That obviously can't work since the "<>" are not really part of the linkage name. The original idea was that we'd use the symbol's language to select the right symbol name matching algorithm, but that doesn't work for Ada because it's not really possible to unambiguously tell from the linkage name alone whether we're dealing with Ada symbols, so Ada minsyms end up with no language set, or sometimes C++ set. So fix this by treating Ada mode specially when determining the linkage name to match against. gdb/ChangeLog: 2018-01-10 Pedro Alves PR gdb/22670 * minsyms.c (linkage_name_str): New function. (iterate_over_minimal_symbols): Use it. gdb/testsuite/ChangeLog: 2018-01-10 Pedro Alves PR gdb/22670 * gdb.ada/bp_c_mixed_case.exp: Remove setup_kfail calls. --- gdb/ChangeLog | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'gdb/ChangeLog') diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 1ea48d0d9a..4c90a5b9dd 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2018-01-10 Pedro Alves + + PR gdb/22670 + * minsyms.c (linkage_name_str): New function. + (iterate_over_minimal_symbols): Use it. + 2018-01-08 Samuel Thibault * gdb/gnu-nat.c: Include and . -- cgit v1.2.3