From 980aa3e6dfeb0f018915f65be4b2987667f31fe9 Mon Sep 17 00:00:00 2001 From: Cupertino Miranda Date: Thu, 21 Jul 2016 15:32:35 +0200 Subject: Dynamic TLS GOT entries would not be relocated. Forgot to set should_relocate to TRUE in case of GOT and TLS relocations of undefined symbols for shared libraries. In dynamic libraries if symbol is not known the instruction relocation would not be resolved to point to the respective .got entry. A test was created to detect similar future mistakes. bfd/ChangeLog: Cupertino Miranda * elf32-arc.c (elf_arc_relocate_section): Changed. Set should_relocate to TRUE for GOT and TLS relocs. ld/ChangeLog: Cupertino Miranda * ld/testsuite/ld-arc/tls_gd-01.s: Added a testcase for this patch. * ld/testsuite/ld-arc/tls_gd-01.d: Likewise. --- bfd/elf32-arc.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'bfd/elf32-arc.c') diff --git a/bfd/elf32-arc.c b/bfd/elf32-arc.c index 5ba170e7fa..b726dab960 100644 --- a/bfd/elf32-arc.c +++ b/bfd/elf32-arc.c @@ -1374,6 +1374,8 @@ elf_arc_relocate_section (bfd * output_bfd, if ((is_reloc_for_GOT (howto) || is_reloc_for_TLS (howto))) { + reloc_data.should_relocate = TRUE; + struct got_entry **list = get_got_entry_list_for_symbol (output_bfd, r_symndx, h); -- cgit v1.2.3